feat(core): switch nx release changelog to offline first with CHANGELOG.md files
#19327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit f343128. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
JamesHenry
force-pushed
the
changelog-files
branch
from
1529ace
to
43c1bbb
Compare
JamesHenry
requested review from
a team,
FrozenPandaz,
vsavkin,
AgentEnder and
jaysoo
as code owners
fahslaj
approved these changes
Sep 27, 2023
FrozenPandaz
approved these changes
Oct 3, 2023
isaacplmann
approved these changes
Oct 3, 2023
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
We initially decided to make
nx release changelogGithub release focused, as that was our own use-case with the Nx repo. It can only work with Github releases.Expected Behavior
nx release changelogis offline first, with a--create-release=githubflag to opt into the Github releases behaviour that was previously the default. It now handles generating and updating a CHANGELOG.md at the root of the workspace by default, although this can be disabled by passing--file=false.Related Issue(s)
Fixes #