-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(nx): fix Sentry example in plugin docs #19338
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@@ -125,7 +125,8 @@ module.exports = async (phase, context) => { | |||
|
|||
// If you have plugins that has to be added after Nx you can do that here. | |||
// For example, Sentry needs to be added last. | |||
updatedConfig = require('@sentry/nextjs')(updatedConfig, { silent: true }); | |||
const { withSentryConfig } = require('@sentry/nextjs'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would have put this line in the top scope but I assume you probably don't want that.
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 47f322e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution
✅ Successfully ran 4 targets
Sent with 💌 from NxCloud. |
Gentle bump :) Seems like this was helpful for at least one user getsentry/sentry-javascript#8982 (comment) |
gentle bump :) |
smol lil gentle bump |
:( |
Thanks a lot for this - also helped in our case... |
Fixing it in this PR: #20413 |
@juristr Thank you! <3 |
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
I noticed that the current Sentry example in the plugin documentation is a bit wrong. This PR fixes that.