Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nx): fix Sentry example in plugin docs #19338

Closed
wants to merge 2 commits into from
Closed

Conversation

lforst
Copy link
Contributor

@lforst lforst commented Sep 26, 2023

I noticed that the current Sentry example in the plugin documentation is a bit wrong. This PR fixes that.

@lforst lforst requested review from a team as code owners September 26, 2023 11:18
@vercel
Copy link

vercel bot commented Sep 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Oct 13, 2023 7:41am

@@ -125,7 +125,8 @@ module.exports = async (phase, context) => {

// If you have plugins that has to be added after Nx you can do that here.
// For example, Sentry needs to be added last.
updatedConfig = require('@sentry/nextjs')(updatedConfig, { silent: true });
const { withSentryConfig } = require('@sentry/nextjs');
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would have put this line in the top scope but I assume you probably don't want that.

@lforst
Copy link
Contributor Author

lforst commented Oct 13, 2023

Gentle bump :) Seems like this was helpful for at least one user getsentry/sentry-javascript#8982 (comment)

@lforst
Copy link
Contributor Author

lforst commented Oct 20, 2023

gentle bump :)

@lforst
Copy link
Contributor Author

lforst commented Nov 7, 2023

smol lil gentle bump

@lforst
Copy link
Contributor Author

lforst commented Nov 23, 2023

:(

@dfr-exnaton
Copy link
Contributor

Thanks a lot for this - also helped in our case...

@juristr
Copy link
Member

juristr commented Nov 24, 2023

Fixing it in this PR: #20413

@juristr juristr closed this Nov 24, 2023
@lforst
Copy link
Contributor Author

lforst commented Nov 24, 2023

@juristr Thank you! <3

Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants