fix(core): pass workingDirectory to executed schematic, if found in schema #19371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…chema The Angular Schematics, e.g. @schematics/angular:service, use the root dir as default, if no path is provided to the schematics. This fix adds the dir the command is executed to the executed schematic. closed nrwl#19308
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 8dda844. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
AgentEnder
approved these changes
Nov 14, 2023
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR forwards the current directory to the schematic as workingDirectory argument, if present in schema.
The Angular Schematics, e.g. @schematics/angular:service, use the root dir as default, if no path is provided to the schematics.
Current Behavior
Executing
npx nx g s fooin a directory other than root e.g. /services, will cause the files to be generated under /src which is false.Expected Behavior
Executing
npx nx g s fooin a directory other than root e.g. /services, will cause the files to be generated under /services/.Related Issue(s)
Fixes #19308