Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): nx build --graph file.json should work in subdirectories #19858

Merged
merged 1 commit into from Feb 2, 2024

Conversation

AgentEnder
Copy link
Member

@AgentEnder AgentEnder commented Oct 25, 2023

Current Behavior

We rewrite argv to support "infix" target notation (e.g. nx build my-app).

Expected Behavior

We don't rewrite infix notation before it reaches yargs, as yargs handles parsing things in a more thorough manner. This eliminates some messy areas in our codebase, but also makes sure that flags passed into commands are interpreted correctly in the presence of positionals. Specifically, this fixes the following cases:

nx build --graph stdout runs the build script for the project that you are inside of instead of looking for a project named stdout

nx build --graph stdout mypkg would be odd to run, but would run the build script for mypkg

nx run-many -t test,build runs test + build

nx run-many -t test build runs test + build

Related Issue(s)

Fixes #

@vercel
Copy link

vercel bot commented Oct 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Jan 30, 2024 9:57pm

@AgentEnder AgentEnder force-pushed the fix/use-standard-args-parsing branch 2 times, most recently from ab29e0b to d7435a4 Compare October 26, 2023 13:16
@AgentEnder AgentEnder requested a review from a team as a code owner October 26, 2023 14:36
@FrozenPandaz FrozenPandaz merged commit 322ecf7 into nrwl:master Feb 2, 2024
6 checks passed
FrozenPandaz pushed a commit that referenced this pull request Feb 2, 2024
FrozenPandaz pushed a commit that referenced this pull request Feb 3, 2024
Copy link

github-actions bot commented Feb 9, 2024

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants