feat(module-federation): use single file-server for static remotes #20006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 1ee425a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
Coly010
force-pushed
the
feat/module-federation-single-file-server
branch
8 times, most recently
from
2997e0e
to
bb84424
Compare
Coly010
force-pushed
the
feat/module-federation-single-file-server
branch
from
bb84424
to
f43120e
Compare
ndcunningham
approved these changes
Nov 8, 2023
jaysoo
reviewed
Nov 9, 2023
packages/react/src/executors/module-federation-dev-server/module-federation-dev-server.impl.ts
Outdated
Show resolved
Hide resolved
jaysoo
reviewed
Nov 9, 2023
packages/react/src/executors/module-federation-dev-server/module-federation-dev-server.impl.ts
Show resolved
Hide resolved
…flict with dev remote port
Coly010
force-pushed
the
feat/module-federation-single-file-server
branch
from
f43120e
to
1ee425a
Compare
jaysoo
approved these changes
Nov 10, 2023
This was referenced Nov 14, 2023
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
We currently spin up a forked process for every static remote to run a file-server for the remote.
Expected Behavior
We should use a single file-server for all the remotes
Related Issue(s)
Fixes #