Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular): serve host app with --skipRemotes='*' #20224

Closed

Conversation

sokolovstas
Copy link

@sokolovstas sokolovstas commented Nov 13, 2023

set --all=false for static remotes building in module-federation-dev-server

Current Behavior

When I run command nx serve web-app --skipRemotes='*' serve failed because I don't have remotes to build. run-many exit with code not 0

Expected Behavior

When I run command nx serve web-app --skipRemotes='*' no remotes builded and only host served

@sokolovstas sokolovstas requested a review from a team as a code owner November 13, 2023 18:24
Copy link

vercel bot commented Nov 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Nov 14, 2023 2:04am

@sokolovstas sokolovstas changed the title Set all to false on remotes build in module federation dev server fix(angular): serve host app with --skipRemotes='*' Nov 13, 2023
@sokolovstas sokolovstas force-pushed the fix-serve-skip-all-for-angularmf branch from 2255919 to d61409f Compare November 14, 2023 02:04
@leosvelperez leosvelperez requested review from Coly010 and removed request for leosvelperez November 14, 2023 08:45
Copy link
Contributor

@Coly010 Coly010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m not sure this is the correct approach to solving this issue.

I’ll have a think about it and respond when I have a better approach.

@Coly010
Copy link
Contributor

Coly010 commented Nov 14, 2023

After testing this, it seems this has already been fixed by #20006

@Coly010 Coly010 closed this Nov 14, 2023
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants