feat(core): independent nx releases and automated git operations #20191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☁️ Nx Cloud ReportCI is running/has finished running commands for commit f83cd73. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
JamesHenry
force-pushed
the
independent-releases
branch
from
1f2d0e4
to
5911aa2
Compare
JamesHenry
changed the title
JamesHenry
commented
Nov 13, 2023
| @@ -602,7 +602,7 @@ describe('nx release', () => { | |||
|
|
|||
|
|
|||
|
|
|||
| > NX Previewing a Github release and an entry in {project-name}/CHANGELOG.md for {project-name}@v1000.0.0-next.0 | |||
There was a problem hiding this comment.
This behaviour was previously incorrect
JamesHenry
commented
Nov 13, 2023
| @@ -213,6 +243,8 @@ To fix this you will either need to add a package.json file at that location, or | |||
| break; | |||
| } | |||
|
|
|||
| // TODO: reevaluate this logic/workflow for independent projects | |||
There was a problem hiding this comment.
@fahslaj will reevaluate prerelease graduation in a follow up
JamesHenry
force-pushed
the
independent-releases
branch
from
5911aa2
to
ea29b58
Compare
JamesHenry
force-pushed
the
independent-releases
branch
from
ea29b58
to
6aa018e
Compare
JamesHenry
changed the title
JamesHenry
force-pushed
the
independent-releases
branch
from
6aa018e
to
b52da21
Compare
JamesHenry
requested review from
a team,
FrozenPandaz,
vsavkin,
AgentEnder and
jaysoo
as code owners
fahslaj
approved these changes
Nov 13, 2023
JamesHenry
commented
Nov 15, 2023
| @@ -172,12 +172,6 @@ const changelogCommand: CommandModule<NxReleaseArgs, ChangelogOptions> = { | |||
| 'Alternate git remote in the form {user}/{repo} on which to create the Github release (useful for testing)', | |||
| default: 'origin', | |||
| }) | |||
| .option('tagVersionPrefix', { | |||
There was a problem hiding this comment.
This was mistakenly left in from previous work
JamesHenry
commented
Nov 15, 2023
JamesHenry
force-pushed
the
independent-releases
branch
from
1401d48
to
a8e2ae0
Compare
JamesHenry
force-pushed
the
independent-releases
branch
from
a8e2ae0
to
ec8805b
Compare
FrozenPandaz
approved these changes
Nov 17, 2023
AgentEnder
approved these changes
Nov 17, 2023
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nx releasecommand executionsversionandchangelogsubcommands for maximum flexibilitynx releasecommands