Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(linter): add create-nodes plugin #20264

Merged
merged 21 commits into from
Nov 30, 2023

Conversation

meeroslav
Copy link
Contributor

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

@meeroslav meeroslav self-assigned this Nov 15, 2023
Copy link

vercel bot commented Nov 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Nov 30, 2023 9:00am

@meeroslav meeroslav force-pushed the feat-eslint-v3-config branch 2 times, most recently from 2220ef2 to 922532c Compare November 22, 2023 21:56
@meeroslav meeroslav added the scope: linter Issues related to Eslint support in Nx label Nov 28, 2023
@meeroslav meeroslav marked this pull request as ready for review November 29, 2023 14:13
@meeroslav meeroslav requested review from a team as code owners November 29, 2023 14:13
@@ -27,16 +27,37 @@
"requirements": {},
"migrations": "./migrations.json"
},
"exports": {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How come this was needed?

Copy link
Contributor Author

@meeroslav meeroslav Nov 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I based it off of @AgentEnder's PR for Playwright assuming that is intended direction we want to take.

I will revert this block entirely

"executors": "./executors.json",
"generators": "./generators.json",
"nx-migrations": {
"migrations": "./migrations.json"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have migrations above.

@FrozenPandaz FrozenPandaz merged commit fe63f85 into nrwl:master Nov 30, 2023
6 checks passed
Copy link

github-actions bot commented Dec 6, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
scope: linter Issues related to Eslint support in Nx
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants