feat(angular): support esbuild-based executors/builders in @nx/angular:dev-server

[leosvelperez]

• Rename @nx/angular:webpack-dev-server to @nx/angular:dev-server
  • Add migration
• Force the underlying @angular-devkit/build-angular:dev-server to use esbuild when the build target executor is @nx/angular:browser-esbuild

Current Behavior

The @nx/angular:webpack-dev-server is a webpack-specific executor that doesn't support the esbuild-based executors/builders.

Expected Behavior

The @nx/angular:webpack-dev-server should be renamed to @nx/angular:dev-server and support the esbuild-based executors/builders.

Related Issue(s)

Fixes #20267
Fixes #20332

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
nx-dev	✅ Ready (Inspect)	Visit Preview	Nov 20, 2023 10:32am

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 661ba17. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

---

✅ Successfully ran 6 targets

• nx affected --target=e2e --base=24b245b2d5d5c8a1739b688b31db9789005d97c6 --head=661ba1712b351583e004547277c7ea6486cd113a --parallel=1
• nx affected --targets=lint,test,build --base=24b245b2d5d5c8a1739b688b31db9789005d97c6 --head=661ba1712b351583e004547277c7ea6486cd113a --parallel=3
• nx run-many -t check-imports check-commit check-lock-files check-codeowners documentation --parallel=1 --no-dte
• nx-cloud record -- nx format:check --base=24b245b2d5d5c8a1739b688b31db9789005d97c6 --head=661ba1712b351583e004547277c7ea6486cd113a
• nx documentation --no-dte
• nx affected -t e2e-macos --parallel=1 --base=24b245b2d5d5c8a1739b688b31db9789005d97c6 --head=661ba1712b351583e004547277c7ea6486cd113a

---

Sent with 💌 from NxCloud.

[ArielGueta]

@leosvelperez thanks for the PR! Two questions:

• It will support the index transformer?
• It will allow passing plugins?

[leosvelperez]

• It will support the index transformer?

Yes.

• It will allow passing plugins?

Not yet. We'll look into supporting that separately.

Please note the Angular CLI builders only support plugins when consuming the builder programmatically, not when running a target through the CLI. So, with the changes on this PR you'll already have the same functionality the Angular CLI builders have to run your project targets. Later, Nx executors will add on top of that and expose a way to provide plugins in your project target configuration.

[ArielGueta]

@leosvelperez I get a schema error when using "executor": "@nx/angular:browser-esbuild":

Data path "" must NOT have additional properties(indexFileTransformer).

If I comment the code in the Angular source code it works. How do we solve it without changing the Angular source code?

[ArielGueta]

One more issue when running nx build production:

NX 'indexFileTransformer' is not found in schema

[ArielGueta]

I also get warnings:

Project 'ui' contains extension with invalid name ($schema).
Project 'ui' contains extension with invalid name (tags).

[github-actions]

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.