fix(testing): update the cypress plugin implementation #20314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 3ae5688. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
FrozenPandaz
force-pushed
the
cypress-updates
branch
5 times, most recently
from
ea952fb
to
be6f376
Compare
AgentEnder
reviewed
Nov 17, 2023
| @@ -57,19 +63,27 @@ describe('@nx/cypress/plugin', () => { | |||
| "projectType": "application", | |||
| "targets": { | |||
| "e2e": { | |||
| "cache": true, | |||
| "executor": "@nx/cypress:cypress", | |||
| "cache": false, | |||
AgentEnder
reviewed
Nov 18, 2023
| targets[options.targetName] = { | ||
| ...baseTargetConfig, | ||
| command: `cypress run --config-file ${relativeConfigPath} --e2e --env.devServerTarget ${devServerTargets?.default}`, |
There was a problem hiding this comment.
This is coming from cypress config's env already, do we really need to pass it again via cli?
FrozenPandaz
force-pushed
the
cypress-updates
branch
2 times, most recently
from
65cd3ff
to
9bd8dee
Compare
FrozenPandaz
force-pushed
the
cypress-updates
branch
from
9bd8dee
to
3ae5688
Compare
AgentEnder
approved these changes
Nov 20, 2023
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
The cypress targets are generated to use the
@nx/cypress:cypressexecutor.Expected Behavior
The cypress targets are generated to simply run a command. This will make it easier to understand and also ensure that the behavior is the same as running the cypress commands
Related Issue(s)
Fixes #