Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(release): default to only publishing libs when no config is defined #20315

Merged
merged 7 commits into from
Nov 22, 2023

Conversation

fahslaj
Copy link
Contributor

@fahslaj fahslaj commented Nov 17, 2023

Current Behavior

nx release version fails in a newly created nx repo with any apps.

Expected Behavior

nx release version succeeds in a newly created nx repo with any apps.

Related Issue(s)

Fixes #

Copy link

vercel bot commented Nov 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Nov 22, 2023 5:34pm

@fahslaj fahslaj marked this pull request as ready for review November 20, 2023 17:18
@fahslaj fahslaj requested a review from a team as a code owner November 20, 2023 17:18
Copy link
Collaborator

@JamesHenry JamesHenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feedback on slack

@JamesHenry JamesHenry merged commit d2b444c into nrwl:master Nov 22, 2023
6 checks passed
@fahslaj fahslaj deleted the fix/skip-apps-zero-config branch November 22, 2023 20:17
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants