Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(misc): add args to command in run-commands before unparsed args #20506

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

FrozenPandaz
Copy link
Collaborator

Current Behavior

When run-commands is configured like the following:

{
  command: 'echo',
  options: {
    'args': 'Hello World'
  }
}

The resulting command which is run does not have the args.

Expected Behavior

When run-commands is configured like the following:

{
  command: 'echo',
  options: {
    'args': 'Hello World'
  }
}

The resulting command which is run does have the args.

The user can still pass additional args after that as well

nx echo Jason when the config is:

{
  command: 'echo',
  options: {
    args: 'Hello'
  }
}

Will run echo Hello Jason

Related Issue(s)

Fixes #

@FrozenPandaz FrozenPandaz requested a review from a team as a code owner November 30, 2023 15:57
Copy link

vercel bot commented Nov 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Nov 30, 2023 3:57pm

@FrozenPandaz FrozenPandaz enabled auto-merge (squash) November 30, 2023 19:04
@FrozenPandaz FrozenPandaz merged commit 2cce1f5 into nrwl:master Nov 30, 2023
6 checks passed
Copy link

github-actions bot commented Dec 6, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants