Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(repo): fix release script to look for new node auth token #20590

Merged
merged 1 commit into from
Dec 5, 2023

Conversation

FrozenPandaz
Copy link
Collaborator

@FrozenPandaz FrozenPandaz commented Dec 5, 2023

Current Behavior

The environment variable for running the publish workflow in github actions changed to NODE_AUTH_TOKEN but the release script was still looking for NPM_TOKEN

Expected Behavior

The release script looks for NODE_AUTH_TOKEN

https://github.com/nrwl/nx/actions/runs/7105681620

Copy link

vercel bot commented Dec 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Dec 5, 2023 7:36pm

Copy link

nx-cloud bot commented Dec 5, 2023

@FrozenPandaz FrozenPandaz marked this pull request as ready for review December 5, 2023 19:38
@JamesHenry JamesHenry merged commit cfd8c89 into master Dec 5, 2023
16 of 17 checks passed
@JamesHenry JamesHenry deleted the fix-publish-npm-token branch December 5, 2023 19:59
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants