fix(core): run-commands should handle signals correctly #20611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit fa6d731. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution
✅ Successfully ran 5 targets
Sent with 💌 from NxCloud. |
jaysoo
force-pushed
the
fix/run-commands-exit-gracefully
branch
3 times, most recently
from
ba90010
to
6d37011
Compare
FrozenPandaz
approved these changes
Dec 6, 2023
jaysoo
force-pushed
the
fix/run-commands-exit-gracefully
branch
2 times, most recently
from
2cb9f0d
to
e9a90f2
Compare
AgentEnder
approved these changes
Dec 6, 2023
jaysoo
force-pushed
the
fix/run-commands-exit-gracefully
branch
6 times, most recently
from
40065fc
to
189953b
Compare
jaysoo
force-pushed
the
fix/run-commands-exit-gracefully
branch
from
189953b
to
fa6d731
Compare
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The exit handlers were not being called, thus long-running child process never exits.
Current Behavior
Long-running child processes are left dangling after the run. e.g. when you run e2e, it does not kill the server started through
run-commands/Expected Behavior
Long-running child processes should exit.
Related Issue(s)
Fixes #