feat(misc): update minimatch version used across packages #21207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 85d3cf6. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Let me confirm some things with the rust glob utils. We want to make sure that and minimatch have the same behavior |
Cammisuli
approved these changes
Jan 18, 2024
FrozenPandaz
approved these changes
Jan 18, 2024
leosvelperez
force-pushed
the
misc/bump-minimatch
branch
from
dbd0762
to
85d3cf6
Compare
jaysoo
approved these changes
Jan 18, 2024
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps the minimatch version used across packages to get several fixes made in the latest versions.
With this, we specifically address an issue with the tree-aware glob search helper where globstart matching (
**) was not matching zero path portions (e.g.**/*.txtwould matcha/foo.txtbut notfoo.txt).Current Behavior
Expected Behavior
Related Issue(s)
Fixes #