-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(js): replace publish script with nx release config #21474
feat(js): replace publish script with nx release config #21474
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 697fd3e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let’s discuss on slack
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Several small comments, nothing major 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Several small comments, nothing major 🎉
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Current Behavior
The
@nx/js:library
andcreate-nx-plugin
generators use a custom publish script for publishing packages.Expected Behavior
The
@nx/js:library
andcreate-nx-plugin
generators usenx release publish
to publish packages.Additional changes:
"private": true
in newly generated package.json files when--publishable
is not passed (it already updated existing ones to have"private": true
in this case)nx release version
programmatic api now supportsgeneratorOptionsOverrides
release.version.preVersionCommand
config option that is a command that will be run after validation, but before versioning. This is useful for building artifacts, and is added automatically by the@nx/js:library
generator."private": true
set in package.json by default when no projects config is specified