Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react): ensure playwright configuration is using correct port in app gen #21941

Merged
merged 1 commit into from
Feb 23, 2024

Conversation

Coly010
Copy link
Contributor

@Coly010 Coly010 commented Feb 22, 2024

Current Behavior

When selecting playwright as the e2e test runner for module federation applications it generates an incorrect playwright config.
It only points at :4200 which will be incorrect for remote applications.

This causes playwright to wait for a dev server port to open which will never open.

Expected Behavior

Use the correct port in app gen when configuring playwright to allow for successful e2e setup.

Related Issue(s)

Fixes #

@Coly010 Coly010 requested a review from a team as a code owner February 22, 2024 11:31
@Coly010 Coly010 requested a review from jaysoo February 22, 2024 11:31
@Coly010 Coly010 self-assigned this Feb 22, 2024
Copy link

vercel bot commented Feb 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Feb 23, 2024 10:06am

@Coly010 Coly010 force-pushed the module-federation/react-playwright branch 3 times, most recently from 61f2bb7 to 917ac8e Compare February 22, 2024 15:22
@Coly010 Coly010 force-pushed the module-federation/react-playwright branch from 917ac8e to 6d56b7b Compare February 23, 2024 10:05
@Coly010 Coly010 merged commit c9c56a2 into nrwl:master Feb 23, 2024
6 checks passed
@Coly010 Coly010 deleted the module-federation/react-playwright branch February 23, 2024 11:25
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants