Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(release): currentVersionResolver: git-tag should prefer merged tags #22082

Merged
merged 5 commits into from
Feb 29, 2024

Conversation

fahslaj
Copy link
Contributor

@fahslaj fahslaj commented Feb 29, 2024

Current Behavior

nx release will look at all tags on the repo when determining the current version with currentVersionResolver: 'git-tag'.

Expected Behavior

nx release will prefer tags on the repo that are reachable from the current commit when determining the current version with currentVersionResolver: 'git-tag'. This allows us to support multiple release branches.

Copy link

vercel bot commented Feb 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Feb 29, 2024 8:20pm

@fahslaj fahslaj marked this pull request as ready for review February 29, 2024 18:07
@fahslaj fahslaj requested a review from a team as a code owner February 29, 2024 18:07
@fahslaj fahslaj enabled auto-merge (squash) February 29, 2024 20:26
@fahslaj fahslaj changed the title fix(release): currentVersionResolver: git-tag should only consider merged tags fix(release): currentVersionResolver: git-tag should prefer merged tags Feb 29, 2024
@fahslaj fahslaj merged commit d705372 into nrwl:master Feb 29, 2024
6 checks passed
@fahslaj fahslaj deleted the fix/git-tag-branch-filter branch February 29, 2024 20:59
Copy link

github-actions bot commented Mar 6, 2024

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants