feat(gradle): add gradle init generator #22245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiongemi
requested review from
FrozenPandaz,
vsavkin,
AgentEnder,
jaysoo and
JamesHenry
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 04dbf22. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
xiongemi
force-pushed
the
feature/nxc-352-nx-init-works-in-a-gradle-generated-workspace
branch
4 times, most recently
from
9d92585
to
a35e7c7
Compare
xiongemi
force-pushed
the
feature/nxc-352-nx-init-works-in-a-gradle-generated-workspace
branch
from
a35e7c7
to
a4e0ad5
Compare
FrozenPandaz
requested changes
Mar 18, 2024
| @@ -168,6 +175,9 @@ async function detectPlugins(): Promise< | |||
| ); | |||
|
|
|||
| const detectedPlugins = new Set<string>(); | |||
| if (existsSync('gradlew') || existsSync('gradlew.bat')) { | |||
There was a problem hiding this comment.
Move this to after the package.json logic
| }; | ||
| } | ||
|
|
||
| function detectPluginsWithoutPackageJson(): Promise<string[]> { |
There was a problem hiding this comment.
You shouldn't need a separate function
Comment on lines
29
to
30
| process.env.NX_ADD_PLUGINS !== 'false' && | ||
| nxJson.useInferencePlugins !== false; |
There was a problem hiding this comment.
Assume this is always true. We don't need an internal method.
xiongemi
force-pushed
the
feature/nxc-352-nx-init-works-in-a-gradle-generated-workspace
branch
from
a4e0ad5
to
9c108d8
Compare
xiongemi
force-pushed
the
feature/nxc-352-nx-init-works-in-a-gradle-generated-workspace
branch
from
9c108d8
to
04dbf22
Compare
FrozenPandaz
approved these changes
Mar 19, 2024
| "./package.json": "./package.json", | ||
| "./migrations.json": "./migrations.json", | ||
| "./generators.json": "./generators.json", | ||
| "./plugin": "./plugin.js" |
| @@ -1 +1,2 @@ | |||
| export * from './plugin'; | |||
| export { initGenerator } from './src/generators/init/init'; | |||
There was a problem hiding this comment.
Either don't export this for now. Or, expose it under /generators
arekkubaczkowski
pushed a commit
to arekkubaczkowski/nx
that referenced
this pull request
Mar 19, 2024
FrozenPandaz
pushed a commit
that referenced
this pull request
Mar 25, 2024
(cherry picked from commit 6d83dd7)
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Expected Behavior
Related Issue(s)
Fixes #