fix(js): do not write cached lockfile parsed results when an error is… #22526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 5cb4431. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
FrozenPandaz
force-pushed
the
fix-lockfile
branch
from
87becb0
to
27d5f15
Compare
AgentEnder
approved these changes
Mar 26, 2024
FrozenPandaz
force-pushed
the
fix-lockfile
branch
from
27d5f15
to
e72c4b9
Compare
FrozenPandaz
force-pushed
the
fix-lockfile
branch
from
e72c4b9
to
5cb4431
Compare
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… thrown
Current Behavior
When project graph fails to construct during
postinstall, the js plugin still writes a cached parsed lockfile and the graph is incorrectly successful.Expected Behavior
When project graph fails to construct during
postinstall, the js plugin does not write a cached parsed lockfile. The graph is recalculated after thepostinstalland it is correct.Related Issue(s)
Fixes #