feat(core): load native files from tmp location instead of node_modules #22648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxKless
requested review from
a team,
FrozenPandaz,
vsavkin,
AgentEnder,
jaysoo and
JamesHenry
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit ccff88e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
MaxKless
force-pushed
the
native-execution-outside-nodemodules
branch
from
6809bb7
to
6a20bcc
Compare
FrozenPandaz
requested changes
Apr 11, 2024
FrozenPandaz
requested changes
Apr 11, 2024
MaxKless
force-pushed
the
native-execution-outside-nodemodules
branch
from
a52ad76
to
480c972
Compare
MaxKless
force-pushed
the
native-execution-outside-nodemodules
branch
from
6991b52
to
b9d8396
Compare
MaxKless
force-pushed
the
native-execution-outside-nodemodules
branch
2 times, most recently
from
280837b
to
dedb502
Compare
MaxKless
force-pushed
the
native-execution-outside-nodemodules
branch
from
dedb502
to
97efb73
Compare
MaxKless
force-pushed
the
native-execution-outside-nodemodules
branch
from
97efb73
to
1b60ef5
Compare
FrozenPandaz
requested changes
Apr 16, 2024
FrozenPandaz
approved these changes
Apr 17, 2024
Comment on lines
+7
to
+39
| const nxPackages = new Set([ | ||
| '@nx/nx-android-arm64', | ||
| '@nx/nx-android-arm-eabi', | ||
| '@nx/nx-win32-x64-msvc', | ||
| '@nx/nx-win32-ia32-msvc', | ||
| '@nx/nx-win32-arm64-msvc', | ||
| '@nx/nx-darwin-universal', | ||
| '@nx/nx-darwin-x64', | ||
| '@nx/nx-darwin-arm64', | ||
| '@nx/nx-freebsd-x64', | ||
| '@nx/nx-linux-x64-musl', | ||
| '@nx/nx-linux-x64-gnu', | ||
| '@nx/nx-linux-arm64-musl', | ||
| '@nx/nx-linux-arm64-gnu', | ||
| '@nx/nx-linux-arm-gnueabihf', | ||
| ]); | ||
|
|
||
| let nativeBinding = null | ||
| let localFileExisted = false | ||
| let loadError = null | ||
| const localNodeFiles = [ | ||
| 'nx.android-arm64.node', | ||
| 'nx.android-arm-eabi.node', | ||
| 'nx.win32-x64-msvc.node', | ||
| 'nx.win32-ia32-msvc.node', | ||
| 'nx.win32-arm64-msvc.node', | ||
| 'nx.darwin-universal.node', | ||
| 'nx.darwin-x64.node', | ||
| 'nx.darwin-arm64.node', | ||
| 'nx.freebsd-x64.node', | ||
| 'nx.linux-x64-musl.node', | ||
| 'nx.linux-x64-gnu.node', | ||
| 'nx.linux-arm64-musl.node', | ||
| 'nx.linux-arm64-gnu.node', | ||
| 'nx.linux-arm-gnueabihf.node', | ||
| ]; |
There was a problem hiding this comment.
Followup: Can we make these lists by reading package.json?
AgentEnder
pushed a commit
to AgentEnder/nx
that referenced
this pull request
Apr 23, 2024
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Currently native code is loaded straight from the package location in
node_modules(for example anx.darwin-arm64.nodefile).This is causing issues - especially on windows - when trying to delete
node_modulesor reinstalling packages while the file is still held in memory. This often surfaces in Nx Console where the daemon is started in the background.Expected Behavior
Users should be able to delete
node_modulesat will without having to worry about whether the daemon is still running & locking files in the background.Fixes nrwl/nx-console#1863