fix(js): do not default to commonjs type field in package.json

[Coly010]

Current Behavior

The @nx/js:library generator will default the packageJson.type field to commonjs in the following scenarios:

• Rollup Bundler is used
• No bundler is used

Rollup Behaviour

Rollup supports generating both ESM and CJS output files. The build target that is created even specifies that both formats should be used.
However, the @nx/rollup:rollup executor will restrict the output format based on the packageJson.type field.

Therefore, we're always forcing CJS. This can lead to further issues when the package is built and distributed to other repos.

The skipTypeField option is also not respected in commonjs output formats.

No Bundler Behaviour

When no bundler is specified for the library, we still add packageJson.type = commonjs.
This is unnecessarily restrictive and can lead to further behavioural issues.

It is safer to not set a type field and allow the user to specify this themselves based on their needs.

Expected Behavior

Do not default to commonjs for no bundler or with rollup.

Related Issue(s)

Fixes #19384

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

Name	Status	Preview	Updated (UTC)
nx-dev	⬜️ Ignored (Inspect)	Visit Preview	Apr 15, 2024 0:35am

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit a9efb44. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

---

✅ Successfully ran 6 targets

• nx affected --targets=e2e,e2e-ci --base=810a3b5259e1cca504f0616c3a64d427d8d57725 --head=a9efb4417401f1fc7d85e9a6ebe3c173f6514695 --parallel=1
• nx affected --targets=lint,test,build --base=810a3b5259e1cca504f0616c3a64d427d8d57725 --head=a9efb4417401f1fc7d85e9a6ebe3c173f6514695 --parallel=3
• nx run-many -t check-imports check-commit check-lock-files check-codeowners documentation --parallel=1 --no-dte
• nx-cloud record -- nx format:check --base=810a3b5259e1cca504f0616c3a64d427d8d57725 --head=a9efb4417401f1fc7d85e9a6ebe3c173f6514695
• nx documentation --no-dte
• nx affected -t e2e-macos --parallel=1 --base=810a3b5259e1cca504f0616c3a64d427d8d57725 --head=a9efb4417401f1fc7d85e9a6ebe3c173f6514695

---

Sent with 💌 from NxCloud.

[github-actions]

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.