Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(js): experimental tsc entrypoint #22852

Merged
merged 4 commits into from Apr 24, 2024

Conversation

JamesHenry
Copy link
Collaborator

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

Copy link

vercel bot commented Apr 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Apr 23, 2024 9:00pm

Co-authored-by: Leosvel Pérez Espinosa <leosvel.perez.espinosa@gmail.com>
packages/js/typescript-plugin.ts Outdated Show resolved Hide resolved
packages/js/src/plugins/typescript/plugin.ts Show resolved Hide resolved
packages/js/typescript-plugin.ts Outdated Show resolved Hide resolved
packages/js/src/plugins/typescript/plugin.ts Show resolved Hide resolved
command,
options: { cwd: projectRoot },
cache: true,
inputs: getInputs(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Call this once for both build and typecheck outside this if

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are actually a bit different, because they are not always both called and the internal project references can be different, leaving for now

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really? 👀 They look the same to me. In fact, the one from typecheck is reused for build if both are called...

command,
options: { cwd: projectRoot },
cache: true,
inputs: getInputs(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really? 👀 They look the same to me. In fact, the one from typecheck is reused for build if both are called...

@FrozenPandaz FrozenPandaz merged commit 526ea7c into nrwl:master Apr 24, 2024
6 checks passed
Copy link

github-actions bot commented May 1, 2024

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants