New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(js): experimental tsc entrypoint #22852
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit aa715a9. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
Co-authored-by: Leosvel Pérez Espinosa <leosvel.perez.espinosa@gmail.com>
d751c40
to
7fc4ebf
Compare
command, | ||
options: { cwd: projectRoot }, | ||
cache: true, | ||
inputs: getInputs( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Call this once for both build
and typecheck
outside this if
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They are actually a bit different, because they are not always both called and the internal project references can be different, leaving for now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really? 👀 They look the same to me. In fact, the one from typecheck is reused for build if both are called...
command, | ||
options: { cwd: projectRoot }, | ||
cache: true, | ||
inputs: getInputs( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really? 👀 They look the same to me. In fact, the one from typecheck is reused for build if both are called...
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Current Behavior
Expected Behavior
Related Issue(s)
Fixes #