fix(core): local plugins should be able to use {projectRoot} in options block #23068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit dcace4c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
AgentEnder
force-pushed
the
fix/local-plugins-project-root
branch
3 times, most recently
from
12367d1
to
372c839
Compare
AgentEnder
force-pushed
the
fix/local-plugins-project-root
branch
from
372c839
to
dcace4c
Compare
FrozenPandaz
approved these changes
Apr 30, 2024
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ns block
Current Behavior
Local nx plugins registered in
nx.jsonare looked up by their build target'smainoption. This is read from a partial projects configuration without any of the custom plugin inference.Because of how this partial graph was constructed,
{projectRoot}and similar tokens were not properly inlined, resulting in plugin failing to load.Expected Behavior
Tokens are inlined at the time of project configuration construction
Related Issue(s)
Fixes #22940
Fixes #23083