fix(core): migrate should warn if package does not exist #23317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 40123b1. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
AgentEnder
force-pushed
the
fix/migrate-should-warn
branch
2 times, most recently
from
53a8387
to
30902e5
Compare
AgentEnder
force-pushed
the
fix/migrate-should-warn
branch
from
30902e5
to
b3bdffb
Compare
AgentEnder
force-pushed
the
fix/migrate-should-warn
branch
from
b3bdffb
to
40123b1
Compare
FrozenPandaz
approved these changes
May 16, 2024
FrozenPandaz
pushed a commit
that referenced
this pull request
May 21, 2024
<!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> ## Current Behavior Migrations are a noop if the package can't be fetched ## Expected Behavior There is a warning if the package doesn't exist ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes #22308 (cherry picked from commit 7a34a46)
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Migrations are a noop if the package can't be fetched
Expected Behavior
There is a warning if the package doesn't exist
Related Issue(s)
Fixes #22308