fix(node): Docker generator should work #23452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 367a5ab. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
Coly010
approved these changes
May 16, 2024
Also fixes the unit tests for node package closes: #23365
ndcunningham
force-pushed
the
fix/node-docker-generator
branch
from
5fe0c3d
to
367a5ab
Compare
jaysoo
approved these changes
May 16, 2024
FrozenPandaz
pushed a commit
that referenced
this pull request
May 21, 2024
Also fixes the unit tests for node package ## Currently When you generate a docker file using either the node generator or the node:setup-docker generator using inferred targets would create the DockerFile but the COPY command would be incorrect. It would resemble something similar to ``` //... COPY acme //etc... ``` ## Expected Now it generates the correct command. ``` //... COPY dist/acme acme/ //etc... ``` closes: #23365 (cherry picked from commit 1b7cf42)
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixes the unit tests for node package
Currently
When you generate a docker file using either the node generator or the node:setup-docker generator using inferred targets would create the DockerFile but the COPY command would be incorrect.
It would resemble something similar to
Expected
Now it generates the correct command.
closes: #23365