-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@nx/node:setup-docker generator produces invalid Dockerfile #23365
Labels
Comments
FrozenPandaz
added
the
scope: node
Issues related to Node, Express, NestJS support for Nx
label
May 14, 2024
Thanks! This will be fixed in the next release. |
ndcunningham
added a commit
that referenced
this issue
May 16, 2024
Also fixes the unit tests for node package closes: #23365
ndcunningham
added a commit
that referenced
this issue
May 16, 2024
Also fixes the unit tests for node package closes: #23365
ndcunningham
added a commit
that referenced
this issue
May 16, 2024
Also fixes the unit tests for node package ## Currently When you generate a docker file using either the node generator or the node:setup-docker generator using inferred targets would create the DockerFile but the COPY command would be incorrect. It would resemble something similar to ``` //... COPY acme //etc... ``` ## Expected Now it generates the correct command. ``` //... COPY dist/acme acme/ //etc... ``` closes: #23365
FrozenPandaz
pushed a commit
that referenced
this issue
May 21, 2024
Also fixes the unit tests for node package ## Currently When you generate a docker file using either the node generator or the node:setup-docker generator using inferred targets would create the DockerFile but the COPY command would be incorrect. It would resemble something similar to ``` //... COPY acme //etc... ``` ## Expected Now it generates the correct command. ``` //... COPY dist/acme acme/ //etc... ``` closes: #23365 (cherry picked from commit 1b7cf42)
This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Current Behavior
@nx/node:setup-docker produces the following Dockerfile:
Resulting in the following error:
COPY requires at least two arguments
Expected Behavior
Dockerfile utiliizes COPY command correctly, providing the destination path.
GitHub Repo
No response
Steps to Reproduce
Nx Report
Failure Logs
No response
Package Manager Version
No response
Operating System
Additional Information
No response
The text was updated successfully, but these errors were encountered: