fix(js): handle tsconfig file with no compilerOptions #25966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 423a43f. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
jaysoo
approved these changes
May 23, 2024
FrozenPandaz
pushed a commit
that referenced
this pull request
May 24, 2024
Handles adding a root `tsconfig.base.json` when there is a root `tsconfig.json` with no `compilerOptions` property. Prerequisites: Have a repository has a root `tsconfig.json` with no `compilerOptions` property and there is no root `tsconfig.base.json`. Steps to reproduce: 1. Generate a js library (`nx g @nx/js:lib my-lib`) Expected results: Library is created. Actual results: There is an error. ``` NX Cannot read properties of undefined (reading 'rootDir') ``` This PR fixes the error. (cherry picked from commit a1ba0ad)
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handles adding a root
tsconfig.base.jsonwhen there is a roottsconfig.jsonwith nocompilerOptionsproperty.Prerequisites:
Have a repository has a root
tsconfig.jsonwith nocompilerOptionsproperty and there is no roottsconfig.base.json.Steps to reproduce:
nx g @nx/js:lib my-lib)Expected results:
Library is created.
Actual results:
There is an error.
This PR fixes the error.