Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(testing): remove --watch=false from inferred vitest targets to keep things inlined with vitest recommendations #25975

Merged
merged 1 commit into from
May 23, 2024

Conversation

jaysoo
Copy link
Member

@jaysoo jaysoo commented May 23, 2024

Users should use vitest, which will run with watch mode for local dev, and non-watch mode in CI.

If users need to run affected or run-many locally they can always pass --watch=false manually. This is the same as running through npm workspaces or other monorepo tools. IMO, users should be running tests from their IDEs anyway.

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

@jaysoo jaysoo requested a review from a team as a code owner May 23, 2024 19:18
@jaysoo jaysoo requested a review from ndcunningham May 23, 2024 19:18
Copy link

vercel bot commented May 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview May 23, 2024 7:56pm

…eep things inlined with vitest recommendations
@FrozenPandaz FrozenPandaz merged commit 445916f into master May 23, 2024
6 checks passed
@FrozenPandaz FrozenPandaz deleted the feat/vitest-remove-watch-false branch May 23, 2024 20:45
FrozenPandaz pushed a commit that referenced this pull request May 24, 2024
…eep things inlined with vitest recommendations (#25975)

Users should use `vitest`, which will run with watch mode for local dev,
and non-watch mode in CI.

If users need to run `affected` or `run-many` locally they can always
pass `--watch=false` manually. This is the same as running through npm
workspaces or other monorepo tools. IMO, users should be running tests
from their IDEs anyway.

<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

## Current Behavior
<!-- This is the behavior we have today -->

## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #

(cherry picked from commit 445916f)
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants