feat(testing): remove --watch=false from inferred vitest targets to keep things inlined with vitest recommendations #25975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 4ec254e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
jaysoo
force-pushed
the
feat/vitest-remove-watch-false
branch
from
0fbeb4e
to
a3b37c5
Compare
jaysoo
force-pushed
the
feat/vitest-remove-watch-false
branch
from
a3b37c5
to
da66bb1
Compare
…eep things inlined with vitest recommendations
jaysoo
force-pushed
the
feat/vitest-remove-watch-false
branch
from
da66bb1
to
4ec254e
Compare
ndcunningham
approved these changes
May 23, 2024
FrozenPandaz
approved these changes
May 23, 2024
FrozenPandaz
pushed a commit
that referenced
this pull request
May 24, 2024
…eep things inlined with vitest recommendations (#25975) Users should use `vitest`, which will run with watch mode for local dev, and non-watch mode in CI. If users need to run `affected` or `run-many` locally they can always pass `--watch=false` manually. This is the same as running through npm workspaces or other monorepo tools. IMO, users should be running tests from their IDEs anyway. <!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> ## Current Behavior <!-- This is the behavior we have today --> ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes # (cherry picked from commit 445916f)
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users should use
vitest, which will run with watch mode for local dev, and non-watch mode in CI.If users need to run
affectedorrun-manylocally they can always pass--watch=falsemanually. This is the same as running through npm workspaces or other monorepo tools. IMO, users should be running tests from their IDEs anyway.Current Behavior
Expected Behavior
Related Issue(s)
Fixes #