Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bundling): rollup watch mode yields result from async iterable #26160

Merged
merged 1 commit into from
May 28, 2024

Conversation

jaysoo
Copy link
Member

@jaysoo jaysoo commented May 28, 2024

This PR fixes the return from @nx/rollup:rollup executor so that it yields results from the inner async iterable.

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

Copy link

vercel bot commented May 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview May 28, 2024 2:58pm

@jaysoo jaysoo marked this pull request as ready for review May 28, 2024 14:57
@jaysoo jaysoo requested a review from a team as a code owner May 28, 2024 14:57
@jaysoo jaysoo requested a review from ndcunningham May 28, 2024 14:57
@jaysoo jaysoo merged commit 012ce7c into master May 28, 2024
4 of 6 checks passed
@jaysoo jaysoo deleted the fix/rollup-watch-mode branch May 28, 2024 21:16
FrozenPandaz pushed a commit that referenced this pull request May 28, 2024
…26160)

This PR fixes the return from `@nx/rollup:rollup` executor so that it
yields results from the inner async iterable.

## Current Behavior
<!-- This is the behavior we have today -->

## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #

(cherry picked from commit 012ce7c)
Copy link

github-actions bot commented Jun 5, 2024

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants