Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(angular): add missing required property "project" to ng-packagr executor presets #9528

Merged
merged 1 commit into from
Mar 25, 2022

Conversation

leosvelperez
Copy link
Member

Current Behavior

The preset examples for ng-packagr-lite and package executors are missing the required property project and therefore, a warning appears on the live editor highlighting the issue.

Expected Behavior

The preset examples should always contain the default properties.

Related Issue(s)

Fixes #

@leosvelperez leosvelperez self-assigned this Mar 25, 2022
@nx-cloud
Copy link

nx-cloud bot commented Mar 25, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 0b9c21a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 8 targets

Sent with 💌 from NxCloud.

@vercel
Copy link

vercel bot commented Mar 25, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nrwl/nx-dev/6uju3xPfVegVTFVmgVAc8CaNakKU
✅ Preview: https://nx-dev-git-fork-leosvelperez-angular-fix-schema-presets-nrwl.vercel.app

@bcabanes bcabanes enabled auto-merge (squash) March 25, 2022 19:11
@bcabanes bcabanes merged commit 7c0ab03 into nrwl:master Mar 25, 2022
@leosvelperez leosvelperez deleted the angular/fix-schema-presets branch March 29, 2022 10:18
sidmonta pushed a commit to sidmonta/nx that referenced this pull request Apr 2, 2022
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants