Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(cypress): fix headless/headed modes description #9591

Merged
merged 1 commit into from Mar 31, 2022

Conversation

ajsaraujo
Copy link
Contributor

Fixes #9590

@nx-cloud
Copy link

nx-cloud bot commented Mar 29, 2022

@vercel
Copy link

vercel bot commented Mar 29, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nrwl/nx-dev/FjQLj4GEPUsfua2rFUJgZDFucmf3
✅ Preview: https://nx-dev-git-fork-ajsaraujo-patch-1-nrwl.vercel.app

Copy link
Contributor

@barbados-clemens barbados-clemens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for helping keep our docs up to date 😄

the only change is how to use the headed mode. it requires the --watch flag, the --browser alone flag will only change the browser and run in headless mode.

docs/shared/cypress-plugin.md Outdated Show resolved Hide resolved
@barbados-clemens barbados-clemens added scope: testing tools Issues related to Cypress / Jest / Playwright / Vitest support in Nx scope: docs Issues related to generic docs labels Mar 29, 2022
Copy link
Contributor

@barbados-clemens barbados-clemens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

side note: it looks like the commit message isn't in the correct format. you can run yarn check-commit locally to see the error.

@ajsaraujo
Copy link
Contributor Author

@barbados-clemens thanks for the heads up, just fixed the commit message. I noticed that CI was failing but I thought it was some random bug 🤪

@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
scope: docs Issues related to generic docs scope: testing tools Issues related to Cypress / Jest / Playwright / Vitest support in Nx
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation on cypress headed/headless modes is inconsistent
2 participants