-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): prompt users to connect to nx cloud when upgrading major versions #9849
feat(core): prompt users to connect to nx cloud when upgrading major versions #9849
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/nrwl/nx-dev/GZjr79m4bHcuP7riXjX3g2JVBv6B [Deployment for 6fc9776 canceled] |
opts.targetVersion | ||
)) | ||
) { | ||
await connectToNxCloudCommand( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe something like this instead:
We noticed you are migrating to a new major version, but are not taking advantage of Nx Cloud. Nx Cloud can make your CI up to 10 times faster. Learn more about it here: https://nx.app. Would you like to add it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, sounds good. I'll change it out.
Left a comment. Looks good. |
690b9b0
to
6fc9776
Compare
This PR introduced the issue seen in #10144 -- comments were made on the specific lines in the commit |
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
When upgrading between major versions, users should be prompted to connect to nx cloud.