Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: extend AttributeType to XdmfTimeSeries #523

Merged
merged 4 commits into from
Nov 19, 2019
Merged

WIP: extend AttributeType to XdmfTimeSeries #523

merged 4 commits into from
Nov 19, 2019

Conversation

gdmcbain
Copy link
Contributor

This is intended to fix #522.

@gdmcbain
Copy link
Contributor Author

I noticed that the instance method XdmfWriter._attribute_type doesn't refer to its first argument and so could be redefined as static; however, since that class is unrelated to XdmfTimeSeriesWriter, I think they can only share the code by both importing it as a module function from common.

@nschloe nschloe merged commit eea9293 into nschloe:master Nov 19, 2019
@gdmcbain gdmcbain deleted the 522-xdmf-timeseries-vectors branch November 19, 2019 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

write vectors in XDMF time series
2 participants
@gdmcbain @nschloe