added layers and recombine options to extrude, & a test #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nschloe
reviewed
Dec 8, 2017
test/test_layers.py
Outdated
|
|
||
| from os.path import basename | ||
| import meshio | ||
| meshio.write(basename(__file__).split('.')[0].split('_')[1] + '.msh', |
There was a problem hiding this comment.
Well, this can be simplified, it's only for development anyways. How about layers.msh?
There was a problem hiding this comment.
Yes, quite right; c0d656f
nschloe
reviewed
Dec 8, 2017
pygmsh/built_in/geometry.py
Outdated
| def extrude( | ||
| self, | ||
| input_entity, | ||
| translation_axis=None, | ||
| rotation_axis=None, | ||
| point_on_axis=None, | ||
| angle=None, | ||
| layers=None, | ||
| recombine=None |
nschloe
reviewed
Dec 8, 2017
| def extrude( | ||
| self, | ||
| input_entity, | ||
| translation_axis=None, | ||
| rotation_axis=None, | ||
| point_on_axis=None, | ||
| angle=None, | ||
| layers=False, |
There was a problem hiding this comment.
layers is a number, right? If yes, the variable should be called num_layers, and the default should be None. Instead of if layers below, one should test for if layers is [not] None.
|
I'll just apply the changes myself. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As in #85 (before that foundered) including SamMallinson#1 and SamMallinson#2