-
-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added facility to perform translational extrusion of structured meshes #85
Conversation
I'd be awesome to get a simple test for that, too, so I don't accidentally mess it up in the future. For this, you basically only need one file in |
Oh, and you can silence the pylint error |
Hi Nico, |
I tried adding the line too-many-branches to .pylintrc, but it still comes back with the error: ~/src/pygmsh$ pylint pygmsh Your code has been rated at 9.99/10 (previous run: 9.99/10, +0.00) Am I doing something wrong? |
Adding it to Alternatively, you could add the comment
to where there are "too many branches" to only disable the warning locally. |
Custom path
what is the current status for this issue, is it planned to be resolved in the near future? |
extrude as per suggestion of @nschloe on 2017-08-16
Sorry for delay, have added disabling command as per Nico's suggestion of Aug 16, pylint now runs fine. Changes committed and pushed. |
Thanks, the change is essential for my master thesis :) |
I wrote an example, SamMallinson#1, simpler than the ‘malfunctioning bend’ retracted in f200657. It's based on It demonstates the proposed It currently writes The original example wrote a .geo file in order to specify |
new file to test extrude(..., layers=1)
Oops, didn't realize that numpy was only needed in the rotational part of test/test_screw.py; deleted unneeded import in SamMallinson#2 |
The diff of this PR is huge. Not sure what went wrong exactly, but it might be better just moving the changes to a new, clean branch. |
Sorry, I think it's mostly merging things from nschloe/master added since 10 July, looking at master...gdmcbain:translationalExtrude but I'll start afresh to make it easier to assess. |
Closing in favor of PR #109. |
minor change to code for geometry.py. Fixes #83.