render ASCII on windows #18
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I agree with you that it's an issue, but how about simply using ASCII everywhere? I don't really like these big if statements you did there. I mean it looks good enough with just ASCII, I can live with that on linux too. I'll do the conversion myself, it's not hard at all.. Will do it tomorrow for sure. But thanks for the idea, yeah.. it's a good idea. |
|
Done: 51c0dc2c3bd9a5033e |
|
Thanks! FYI, one more this. https://github.com/nsf/tulib/blob/master/buffer.go#L173 |
|
What should I replace it with? :) Maybe '~'? |
|
Replaced the unicode ellipsis with '~'. It is used in other popular apps like Far Manager or Midnight Commander for that role. |
|
it works fine. thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As you know, on windows, there are some unicode points that doesn't render correctly.
For example, east asian ambiguous width. It is not a problem of godit. Not a problem of termbox-go. it is a problem of ambiguous character widths. so i want to suggest to use ASCII characters for rendering borders on windows.
Before
After
Currenly, this is ugly patch. if you want this change, I'll update.