Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add info about using PCA pairs plot and PCA beta coefficients to Usage docs #15

Merged
merged 4 commits into from
Dec 8, 2015

Conversation

asromriell
Copy link
Contributor

Let's try this again...

@nsh87
Copy link
Owner

nsh87 commented Dec 8, 2015

@asromriell: perfect! there's a little icon next to your latest commit - it's an orange circle right now. if you click on it, you'll see Travis CI trying to build the package. if there are any errors in the package or when building the docs (i.e. from your new usage.rst file), it will become a red X. Green checkmark is obviously good...

@nsh87 nsh87 changed the title Usage2 Add info about using PCA pairs plot and PCA beta coefficients to Usage docs Dec 8, 2015
@nsh87
Copy link
Owner

nsh87 commented Dec 8, 2015

@asromriell: fyi, i've taken the logistic regression function you made out for now. scikit-learn's confusion matrix is different than we're used to, so the true positives/true negatives are somewhat switched from how you were getting them. i'm going to implement all the stuff for the project first, then add stuff like this back in b/c i don't have a ton of time left to unit test and check things. i think the best way to include that logistic regression stuff is to output that stuff that you put at the end if someone passes a logistic regression model to summary().

nsh87 added a commit that referenced this pull request Dec 8, 2015
Add info about using PCA pairs plot and PCA beta coefficients to Usage docs
@nsh87 nsh87 merged commit 9b53619 into nsh87:dev Dec 8, 2015
@asromriell
Copy link
Contributor Author

Sounds fine. I wasn't too impressed with what I did with the logistic
regression anyway. And yeah, seaborn never worked for me. And probably will
give other ppl trouble too
On Dec 8, 2015 3:39 AM, "Nikhil Haas" notifications@github.com wrote:

@asromriell https://github.com/asromriell: fyi, i've taken the logistic
regression function you made out for now. scinkit-learn's confusion matrix
is different than we're used to, so the true positives/true negatives are
somewhat switched from how you were getting them. i'm going to implement
all the stuff for the project first, then add stuff like this back in. i
think the best way to include that logistic regression stuff is to output
that stuff that you put at the end if someone passes a logistic regression
model to summary().


Reply to this email directly or view it on GitHub
#15 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants