Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated labelMapLegend text #62

Merged
merged 9 commits into from
Mar 5, 2024
Merged

Conversation

windnagelnsidc
Copy link
Contributor

@windnagelnsidc windnagelnsidc commented Mar 5, 2024

Resolves #61

@mfisher87
Copy link
Member

mfisher87 commented Mar 5, 2024

@windnagelnsidc I updated the description of this PR to set up linkage with the issue it will resolve. When this is merged, the issue will auto-close and change status to Done. Other variations like fixes #61, fix #61, close #61, closes #61, resolve #61, resolves #61 all work the same.

@windnagelnsidc windnagelnsidc marked this pull request as ready for review March 5, 2024 21:59
Copy link
Member

@mfisher87 mfisher87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, but I found some places where operators and numbers were separated by a space, and other places where they weren't. I input some suggestions, and you can click through the menu to approve them if you like! Otherwise, go ahead and reject them and let me know when you're ready and we can merge. If you have the permissions, feel free to merge on your own :)

static/snow-surface-properties/variables.json Outdated Show resolved Hide resolved
static/snow-surface-properties/variables.json Outdated Show resolved Hide resolved
static/snow-surface-properties/variables.json Outdated Show resolved Hide resolved
static/snow-surface-properties/variables.json Outdated Show resolved Hide resolved
static/snow-surface-properties/variables.json Outdated Show resolved Hide resolved
windnagelnsidc and others added 5 commits March 5, 2024 15:18
Co-authored-by: Matt Fisher <mfisher87@gmail.com>
Co-authored-by: Matt Fisher <mfisher87@gmail.com>
Co-authored-by: Matt Fisher <mfisher87@gmail.com>
Co-authored-by: Matt Fisher <mfisher87@gmail.com>
Co-authored-by: Matt Fisher <mfisher87@gmail.com>
@windnagelnsidc windnagelnsidc merged commit a3e1fad into main Mar 5, 2024
3 checks passed
@mfisher87 mfisher87 deleted the update-map-legend-label branch March 5, 2024 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updates to the text on the colorbars
2 participants