Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't recomend getting more information when there are no subcommands #88

Merged
merged 2 commits into from
Sep 19, 2018

Conversation

Ponyboy47
Copy link
Contributor

Currently, if you run a command with --help and that command has no subcommands, there will be a message printed by the default HelpGenerator that says:
Use "executable commandName [command] --help" for more information about a command.

This is not necessary if there are no subcommands.

@codecov-io
Copy link

Codecov Report

Merging #88 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #88      +/-   ##
==========================================
+ Coverage   95.19%   95.19%   +<.01%     
==========================================
  Files          40       40              
  Lines        3368     3370       +2     
==========================================
+ Hits         3206     3208       +2     
  Misses        162      162
Impacted Files Coverage Δ
Tests/GuakaTests/HelpGeneratorTests.swift 100% <100%> (ø) ⬆️
Tests/GuakaTests/HelpTests.swift 100% <100%> (ø) ⬆️
Sources/Guaka/Help/HelpGeneratorDefaults.swift 97.53% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef9dfb6...59c247a. Read the comment docs.

Copy link
Collaborator

@thii thii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I've always wanted to fix this.

@thii thii merged commit a1485a7 into nsomar:master Sep 19, 2018
@Ponyboy47 Ponyboy47 deleted the informationSection branch September 19, 2018 22:31
@thii
Copy link
Collaborator

thii commented Sep 28, 2018

This was released as part of 0.3.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants