Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEOFS_HTTP_GATE parameter not clear #11

Open
carpawell opened this issue Nov 3, 2023 · 1 comment
Open

NEOFS_HTTP_GATE parameter not clear #11

carpawell opened this issue Nov 3, 2023 · 1 comment
Labels
config Configuration format update or breaking change I3 Minimal impact question Further information is requested S4 Routine U4 Nothing urgent

Comments

@carpawell
Copy link
Member

Problem

This parameter confuses me as a regular user. Usually, I read the parameters of any function/action as a part of its code: if it needs it, it should use it and I can understand it better. How http gate is used in this action?

Context

Why do we need this parameter? It is a http gate that should be connected to a storage node used for object download. However, it is not used for object downloading, is not validated, and is not checked for an http-SN relation. It also does not simplify action usability: a user has to figure out the correct http gateway himself anyway, no matter if it happens after the objects download or before CI workflow creation. If he knows it, he can use it. If he does not need it, he doesn't want to find it (hehe, neofs does not live for browsers only), he should be able to omit it (once again, http is not a required thing for the action literally named "push to neofs").

@carpawell carpawell added the question Further information is requested label Nov 3, 2023
@roman-khimov roman-khimov added U4 Nothing urgent S4 Routine I3 Minimal impact config Configuration format update or breaking change labels Dec 20, 2023
@roman-khimov
Copy link
Member

Related to #18.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
config Configuration format update or breaking change I3 Minimal impact question Further information is requested S4 Routine U4 Nothing urgent
Projects
None yet
Development

No branches or pull requests

2 participants