Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider changing NEOFS_HTTP_GATE to HTTP_URL_PREFIX #18

Open
roman-khimov opened this issue Mar 28, 2024 · 2 comments
Open

Consider changing NEOFS_HTTP_GATE to HTTP_URL_PREFIX #18

roman-khimov opened this issue Mar 28, 2024 · 2 comments
Labels
enhancement Improving existing functionality I2 Regular impact S3 Minimally significant U3 Regular
Milestone

Comments

@roman-khimov
Copy link
Member

Is your feature request related to a problem? Please describe.

I'm always frustrated when we're referring to outdated components (HTTP gateway) and using instance-specific configurations by default (/$CID/path only works because of rewrites, it's not a native HTTP or REST interface). There also can be cases where people run a gate of their own with some better URL scheme (like reports.example.com/path) and NEOFS_HTTP_GATE puts too many restrictions on them (implying /$CID/path)

Describe the solution you'd like

Rework NEOFS_HTTP_GATE into HTTP_URL_PREFIX (but keep old one for compatibility unles HTTP_URL_PREFIX is set), this would work like

HTTP_URL_PREFIX=https://rest.fs.neo.org/$CID/
HTTP_URL_PREFIX=https://reports.nspcc.io/

leaving gateway/rewrite specifics out of scope.

Additional context

nspcc-dev/neofs-rest-gw#156

@roman-khimov roman-khimov added U3 Regular enhancement Improving existing functionality S3 Minimally significant I2 Regular impact labels Mar 28, 2024
@roman-khimov
Copy link
Member Author

roman-khimov commented Mar 28, 2024

In fact, BASE_URL that's used internally is exactly that, it just needs to be exposed properly. And it includes URL_PREFIX as well.

roman-khimov added a commit that referenced this issue Mar 28, 2024
Don't mention HTTP gateway, it's gone. REST works the same way now.

Refs. #18.

Signed-off-by: Roman Khimov <roman@nspcc.ru>
@roman-khimov
Copy link
Member Author

URL_PREFIX makes no sense in this scheme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improving existing functionality I2 Regular impact S3 Minimally significant U3 Regular
Projects
None yet
Development

No branches or pull requests

1 participant