Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MaxFreeTransactionsPerBlock limit doesn't work correctly #1019

Closed
roman-khimov opened this issue Jun 8, 2020 · 1 comment
Closed

MaxFreeTransactionsPerBlock limit doesn't work correctly #1019

roman-khimov opened this issue Jun 8, 2020 · 1 comment
Labels
bug Something isn't working
Milestone
v0.76.0

Comments

@roman-khimov
Copy link
Member

Testnet node configured with

  MaxTransactionsPerBlock: 500
  MaxFreeTransactionsPerBlock: 20

puts 500 free transactions in a block:
https://neoscan-testnet.io/block/2d612bea91111aa38d39365766f6a2c7309a6425edd68aa0194d2cb27f7a923f
https://neoscan-testnet.io/block/e7c4b81535398864bf47a92e691dd783371f546919ffab9d4d534edfa6c6b6bb
https://neoscan-testnet.io/block/c71d375ab4732f5e01a24c86ab00ba0e282f92d21aef81e6d2e4bf7c4dbf31cc

But it shouldn't.
@roman-khimov roman-khimov added this to the v0.75.1-neox1 milestone Jun 8, 2020
@roman-khimov roman-khimov added the bug Something isn't working label Jun 8, 2020
@roman-khimov
Copy link
Member Author

Related to #370.

roman-khimov added a commit that referenced this issue Jun 8, 2020
@roman-khimov
core: respect MaxFreeTransactionsPerBlock setting
6437f4b 
Fix #1019.
@roman-khimov roman-khimov mentioned this issue Jun 8, 2020
Merged
@roman-khimov roman-khimov modified the milestones: v0.75.1-neox1, v0.76.0 Jun 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
v0.76.0
Development

No branches or pull requests
1 participant
@roman-khimov