Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rpc: adjust getrawmempool RPC-call #1182

Closed
AnnaShaleva opened this issue Jul 16, 2020 · 2 comments · Fixed by #1236
Closed

rpc: adjust getrawmempool RPC-call #1182

AnnaShaleva opened this issue Jul 16, 2020 · 2 comments · Fixed by #1236
Labels
rpc RPC server and client
Milestone
v0.91.0

Comments

@AnnaShaleva
Copy link
Member

There should present verified and non-verified transactions, so it may affects the mempool itself.
@AnnaShaleva AnnaShaleva added feature Completely new functionality neo3 labels Jul 16, 2020
@AnnaShaleva AnnaShaleva mentioned this issue Jul 16, 2020
Closed
@roman-khimov
Copy link
Member

We only store verified transactions, non-verified transactions just don't exist in neo-go.

@roman-khimov roman-khimov added this to the v0.91.0 milestone Jul 16, 2020
@roman-khimov
Copy link
Member

So what we need to do here is to add support for boolean parameter and change the response accordingly. But our unverified list will always be empty.

@roman-khimov roman-khimov added rpc RPC server and client and removed feature Completely new functionality neo3 labels Jul 17, 2020
AnnaShaleva added a commit that referenced this issue Jul 27, 2020
@AnnaShaleva
rpc: update getrawmempool RPC-call result
36c2f0e 
Closes #1182
@AnnaShaleva AnnaShaleva mentioned this issue Jul 27, 2020
Merged
AnnaShaleva added a commit that referenced this issue Jul 28, 2020
@AnnaShaleva
rpc: update getrawmempool RPC-call result
9224c6f 
Closes #1182
AnnaShaleva added a commit that referenced this issue Jul 29, 2020
@AnnaShaleva
rpc: update getrawmempool RPC-call result
990db9f 
Closes #1182
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
rpc RPC server and client
Projects
None yet
Milestone
v0.91.0
Development

Successfully merging a pull request may close this issue.

rpc: update getrawmempool and getrawtransaction RPC-calls nspcc-dev/neo-go
2 participants
@roman-khimov @AnnaShaleva