rpc: update getrawmempool and getrawtransaction RPC-calls
#1236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fyrchik
reviewed
Jul 27, 2020
pkg/rpc/server/server.go
Outdated
Comment on lines
467
to
470
| var getVerified bool | ||
| if len(reqParams) > 0 { | ||
| getVerified = reqParams.Value(0).GetBoolean() | ||
| } |
There was a problem hiding this comment.
There is no need to check parameters count: getVerified := reqParams.Value(0).GetBoolean()
AnnaShaleva
force-pushed
the
rpc/getrawmempool
branch
from
6afcceb
to
daf44ed
Compare
Codecov Report
@@ Coverage Diff @@
## master #1236 +/- ##
==========================================
- Coverage 66.74% 66.72% -0.02%
==========================================
Files 200 200
Lines 17159 17171 +12
==========================================
+ Hits 11452 11458 +6
- Misses 5092 5098 +6
Partials 615 615
Continue to review full report at Codecov.
|
roman-khimov
approved these changes
Jul 28, 2020
pkg/rpc/server/server.go
Outdated
| @@ -693,9 +693,13 @@ func (s *Server) getrawtransaction(reqParams request.Params) (interface{}, *resp | |||
| header, err := s.chain.GetHeader(_header) | |||
| if err != nil { | |||
| resultsErr = response.NewInvalidParamsError(err.Error(), err) | |||
| } else { | |||
| results = result.NewTransactionOutputRaw(tx, header, s.chain) | |||
| return nil, resultsErr | |||
There was a problem hiding this comment.
return nil, response.NewInvalidParamsError(err.Error(), err)?
pkg/rpc/server/server.go
Outdated
| @@ -463,13 +463,20 @@ func (s *Server) getPeers(_ request.Params) (interface{}, *response.Error) { | |||
| return peers, nil | |||
| } | |||
|
|
|||
| func (s *Server) getRawMempool(_ request.Params) (interface{}, *response.Error) { | |||
| func (s *Server) getRawMempool(reqParams request.Params) (interface{}, *response.Error) { | |||
| getVerified := reqParams.Value(0).GetBoolean() | |||
There was a problem hiding this comment.
It's more like verbose flag, getVerified looks a bit strange to me.
Closes #1183. Added VMState to transaction output raw.
AnnaShaleva
force-pushed
the
rpc/getrawmempool
branch
from
daf44ed
to
0c424a0
Compare
fyrchik
approved these changes
Jul 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1182, closes #1183.