Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend getversion RPC response with RPC server settings #3276

Closed
AnnaShaleva opened this issue Dec 20, 2023 · 2 comments · Fixed by #3386
Closed

Extend getversion RPC response with RPC server settings #3276

AnnaShaleva opened this issue Dec 20, 2023 · 2 comments · Fixed by #3386
Assignees
@AliceInHunterland
Labels
enhancement Improving existing functionality I3 Minimal impact rpc RPC server and client S3 Minimally significant U3 Regular
Milestone
v0.106.0

Comments

@AnnaShaleva
Copy link
Member

Ref. #3274 (comment). We need to add a set of specific RPC server settings to getversion RPC response: SessionsEnabled, MaxIteratorResultItems, etc. so that RPC client can benefit from it.
@AnnaShaleva AnnaShaleva added rpc RPC server and client enhancement Improving existing functionality labels Dec 20, 2023
@roman-khimov roman-khimov added I3 Minimal impact U3 Regular S3 Minimally significant labels Dec 21, 2023
@fyfyrchik fyfyrchik mentioned this issue Feb 21, 2024
Closed
@roman-khimov
Copy link
Member

Let's consider this without etc, just two options that are easy to probe from outside and that can be useful for clients to know without probing.

@roman-khimov roman-khimov mentioned this issue Feb 21, 2024
Closed
@roman-khimov roman-khimov added this to the v0.106.0 milestone Feb 21, 2024
@roman-khimov
Copy link
Member

See neo-project/neo-modules#878. The only problem is sessionenabled vs sessionsenabled.

AliceInHunterland added a commit that referenced this issue Apr 1, 2024
@AliceInHunterland
rpcsrv: add SessionEnabled, MaxIteratorResultItems to getversion
e37967b 
Extend getversion RPC response with RPC server settings (SessionEnabled,
MaxIteratorResultItems).Port neo-project/neo-modules#878.

Close #3276

Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>
@AliceInHunterland AliceInHunterland mentioned this issue Apr 1, 2024
Merged
AliceInHunterland added a commit that referenced this issue Apr 2, 2024
@AliceInHunterland
rpcsrv: add SessionEnabled, MaxIteratorResultItems to getversion
65f125a 
Extend getversion RPC response with RPC server settings (SessionEnabled,
MaxIteratorResultItems).Port neo-project/neo-modules#878.

Close #3276

Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>
AliceInHunterland added a commit that referenced this issue Apr 2, 2024
@AliceInHunterland
rpcsrv: add SessionEnabled, MaxIteratorResultItems to getversion
404dac0 
Extend getversion RPC response with RPC server settings (SessionEnabled,
MaxIteratorResultItems).Port neo-project/neo-modules#878.

Close #3276

Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>
AliceInHunterland added a commit that referenced this issue Apr 2, 2024
@AliceInHunterland
rpcsrv: add SessionEnabled, MaxIteratorResultItems to getversion
82eddd7 
Extend getversion RPC response with RPC server settings (SessionEnabled,
MaxIteratorResultItems).Port neo-project/neo-modules#878.

Close #3276

Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>
AliceInHunterland added a commit that referenced this issue Apr 2, 2024
@AliceInHunterland
rpcsrv: add SessionEnabled, MaxIteratorResultItems to getversion
fad81b7 
Extend getversion RPC response with RPC server settings (SessionEnabled,
MaxIteratorResultItems).Port neo-project/neo-modules#878.

Close #3276

Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>
AliceInHunterland added a commit that referenced this issue Apr 2, 2024
@AliceInHunterland
rpcsrv: add SessionEnabled, MaxIteratorResultItems to getversion
2192dd0 
Extend getversion RPC response with RPC server settings (SessionEnabled,
MaxIteratorResultItems).Port neo-project/neo-modules#878.

Close #3276

Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>
AliceInHunterland added a commit that referenced this issue Apr 3, 2024
@AliceInHunterland
rpcsrv: add SessionEnabled, MaxIteratorResultItems to getversion
2620eb8 
Extend getversion RPC response with RPC server settings (SessionEnabled,
MaxIteratorResultItems).Port neo-project/neo-modules#878.

Close #3276

Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>
AliceInHunterland added a commit that referenced this issue Apr 3, 2024
@AliceInHunterland
rpcsrv: add SessionEnabled, MaxIteratorResultItems to getversion
c31878c 
Extend getversion RPC response with RPC server settings (SessionEnabled,
MaxIteratorResultItems).Port neo-project/neo-modules#878.

Close #3276

Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>
AliceInHunterland added a commit that referenced this issue Apr 3, 2024
@AliceInHunterland
rpcsrv: add SessionEnabled, MaxIteratorResultItems to getversion
62fe548 
Extend getversion RPC response with RPC server settings (SessionEnabled,
MaxIteratorResultItems).Port neo-project/neo-modules#878.

Close #3276

Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>
AliceInHunterland added a commit that referenced this issue Apr 3, 2024
@AliceInHunterland
rpcsrv: add SessionEnabled, MaxIteratorResultItems to getversion
686c77a 
Extend getversion RPC response with RPC server settings (SessionEnabled,
MaxIteratorResultItems).Port neo-project/neo-modules#878.

Close #3276

Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AliceInHunterland AliceInHunterland

Labels
enhancement Improving existing functionality I3 Minimal impact rpc RPC server and client S3 Minimally significant U3 Regular
Projects
None yet
Milestone
v0.106.0
Development

Successfully merging a pull request may close this issue.

rpcsrv: add SessionEnabled, MaxIteratorResultItems to getversion nspcc-dev/neo-go
3 participants
@roman-khimov @AnnaShaleva @AliceInHunterland