Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deduplicate RPC types #510

Closed
roman-khimov opened this issue Nov 19, 2019 · 1 comment · Fixed by #676
Closed

Deduplicate RPC types #510

roman-khimov opened this issue Nov 19, 2019 · 1 comment · Fixed by #676
Assignees
Labels
help wanted Extra attention is needed rpc RPC server and client
Milestone

Comments

@roman-khimov
Copy link
Member

We have some number of types defined in the rpc package that represent the structures being passed from server to client, but those are mostly used by the client code. At the same time we have similar types defined in the rpc/wrappers that are used by the server code. There is an obvious duplication there but to make things even more fun we have a third definition of these types for test code in the rpc/server_helper_test.go.

I think we should move all of them into one package separate from the rpc logic, that package can be shared between server and client code (that technically are also good candidates for package split).

@roman-khimov roman-khimov added help wanted Extra attention is needed rpc RPC server and client labels Nov 19, 2019
@roman-khimov roman-khimov added this to the v0.70.0 milestone Nov 19, 2019
@roman-khimov roman-khimov modified the milestones: v0.70.0, v0.70.1 Nov 27, 2019
@roman-khimov roman-khimov modified the milestones: v0.70.1, v0.71.0 Dec 16, 2019
@roman-khimov roman-khimov self-assigned this Dec 18, 2019
@roman-khimov roman-khimov modified the milestones: v0.71.0, v0.72.0 Dec 30, 2019
@roman-khimov roman-khimov modified the milestones: v0.72.0, v0.73.0 Jan 21, 2020
@roman-khimov roman-khimov removed their assignment Feb 17, 2020
@roman-khimov
Copy link
Member Author

Take a look at dedup-rpc-types branch. I think we can also separate client and server code into different packages while here.

@roman-khimov roman-khimov modified the milestones: v0.73.0, v0.74.0 Feb 19, 2020
@roman-khimov roman-khimov self-assigned this Feb 20, 2020
roman-khimov added a commit that referenced this issue Feb 21, 2020
Split up RPC into separate packages

Closes #510.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed rpc RPC server and client
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants