Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge Invoke* types in RPC code #689

Closed
roman-khimov opened this issue Feb 21, 2020 · 0 comments
Closed

Merge Invoke* types in RPC code #689

roman-khimov opened this issue Feb 21, 2020 · 0 comments
Assignees
@roman-khimov
Labels
rpc RPC server and client
Milestone
v0.74.0

Comments

@roman-khimov
Copy link
Member

One thing left after the #510 is response.InvokeResult vs result.Invoke vs server.InvokeFunctionResult, but it relates to and depends on changes planned for #500, so we'll wait a little. In general, I think we're better not involving vm package into this, but it shouldn't be a problem to convert vm.Stack into []request.FuncParam or similar type from smartcontract.
@roman-khimov roman-khimov added this to the v0.74.0 milestone Feb 21, 2020
@roman-khimov roman-khimov added the rpc RPC server and client label Feb 21, 2020
AnnaShaleva added a commit that referenced this issue Feb 26, 2020
@AnnaShaleva
rpc/smartcontract: merge contract parameter types
a7da9e8 
Closes #689

Merged two types:
	- smartcontract.ParamType
	- rpc.StackParamType
into single one:
	- smartcontract.ParameterType
as they duplicated the functionality.

NOTE: type smartcontract.MapType was added (as in C# implementation).

From now, list of supported smartcontract parameter types:
	UnknownType
	SignatureType
	BoolType
	IntegerType
	Hash160Type
	Hash256Type
	ByteArrayType
	PublicKeyType
	StringType
	ArrayType
	MapType
	InteropInterfaceType
	VoidType
@AnnaShaleva AnnaShaleva mentioned this issue Feb 26, 2020
Merged
AnnaShaleva added a commit that referenced this issue Feb 27, 2020
@AnnaShaleva
rpc/smartcontract: merge contract parameter types
29b72c3 
Closes #689

Merged two types:
	- smartcontract.ParamType
	- rpc.StackParamType
into single one:
	- smartcontract.ParameterType
as they duplicated the functionality.

NOTE: type smartcontract.MapType was added (as in C# implementation).

From now, list of supported smartcontract parameter types:
	UnknownType
	SignatureType
	BoolType
	IntegerType
	Hash160Type
	Hash256Type
	ByteArrayType
	PublicKeyType
	StringType
	ArrayType
	MapType
	InteropInterfaceType
	VoidType
AnnaShaleva added a commit that referenced this issue Feb 27, 2020
@AnnaShaleva
rpc/smartcontract: merge contract parameter types
d8d99fe 
Closes #689

Merged two types:
	- smartcontract.ParamType
	- rpc.StackParamType
into single one:
	- smartcontract.ParameterType
as they duplicated the functionality.

NOTE: type smartcontract.MapType was added (as in C# implementation).

From now, list of supported smartcontract parameter types:
	UnknownType
	SignatureType
	BoolType
	IntegerType
	Hash160Type
	Hash256Type
	ByteArrayType
	PublicKeyType
	StringType
	ArrayType
	MapType
	InteropInterfaceType
	VoidType
@roman-khimov roman-khimov self-assigned this Mar 3, 2020
roman-khimov added a commit that referenced this issue Mar 3, 2020
@roman-khimov
rpc: drop duplicating Invoke* structures
478c6ce 
And use smartcontract.Parameter instead of vm.StackItem where
appropriate. Closes #689.
roman-khimov added a commit that referenced this issue Mar 3, 2020
@roman-khimov
rpc: drop duplicating Invoke* structures
01922d0 
And use smartcontract.Parameter instead of vm.StackItem where
appropriate. Closes #689.
@roman-khimov roman-khimov mentioned this issue Mar 3, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@roman-khimov roman-khimov

Labels
rpc RPC server and client
Projects
None yet
Milestone
v0.74.0
Development

No branches or pull requests
1 participant
@roman-khimov