Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add secp256k1 curve support #918

Closed
roman-khimov opened this issue Apr 29, 2020 · 1 comment · Fixed by #1175
Closed

Add secp256k1 curve support #918

roman-khimov opened this issue Apr 29, 2020 · 1 comment · Fixed by #1175
Milestone
v0.91.0

Comments

@roman-khimov
Copy link
Member

Koblitz strikes back (previous episodes: #81, #318, #352)! We need to port neo-project/neo#1419 changes (that are important for cross-chain interoperability) to our system. Some thoughts:

  • it might be a good reason to switch to PublicKey and PrivateKey from crypto/ecdsa package
  • we're only verifying secp256k1, but still if there is some constant-time implementation that would be good to have

See also: neo-project/neo#1614. Related: #917.
@roman-khimov roman-khimov added this to the v0.91.0 milestone Apr 29, 2020
@roman-khimov
Copy link
Member Author

It also is a part of neox-2.x, IIRC.

@roman-khimov roman-khimov mentioned this issue May 29, 2020
Closed
AnnaShaleva added a commit that referenced this issue Jul 13, 2020
@AnnaShaleva
core: rename Neo.Crypto.Verify to Neo.Crypto.VerifyWithECDsaSecp256r1
531c531 
Part of #918
AnnaShaleva added a commit that referenced this issue Jul 13, 2020
@AnnaShaleva
core: rename Neo.Crypto.CheckMultisig to Neo.Crypto.CheckMultisigWith…
d5e6732 
…ECDsaSecp256r1

Part of #918
AnnaShaleva added a commit that referenced this issue Jul 13, 2020
@AnnaShaleva
core: implement Secp256k1 Verify and CheckMultisig interops
f42448b 
Closes #918.
AnnaShaleva added a commit that referenced this issue Jul 13, 2020
@AnnaShaleva
core: rename Neo.Crypto.Verify to Neo.Crypto.VerifyWithECDsaSecp256r1
f3458b5 
Part of #918
AnnaShaleva added a commit that referenced this issue Jul 13, 2020
@AnnaShaleva
core: rename Neo.Crypto.CheckMultisig to Neo.Crypto.CheckMultisigWith…
33bae75 
…ECDsaSecp256r1

Part of #918
AnnaShaleva added a commit that referenced this issue Jul 13, 2020
@AnnaShaleva
core: implement Secp256k1 Verify and CheckMultisig interops
f61a8bf 
Closes #918.
AnnaShaleva added a commit that referenced this issue Jul 13, 2020
@AnnaShaleva
core: implement Secp256k1 Verify and CheckMultisig interops
b42afeb 
Closes #918.
@AnnaShaleva AnnaShaleva mentioned this issue Jul 13, 2020
Merged
AnnaShaleva added a commit that referenced this issue Jul 14, 2020
@AnnaShaleva
core: rename Neo.Crypto.Verify to Neo.Crypto.VerifyWithECDsaSecp256r1
45449a8 
Part of #918
AnnaShaleva added a commit that referenced this issue Jul 14, 2020
@AnnaShaleva
core: rename Neo.Crypto.CheckMultisig to Neo.Crypto.CheckMultisigWith…
02b423a 
…ECDsaSecp256r1

Part of #918
AnnaShaleva added a commit that referenced this issue Jul 14, 2020
@AnnaShaleva
core: implement Secp256k1 Verify and CheckMultisig interops
6429ead 
Closes #918.
AnnaShaleva added a commit that referenced this issue Jul 14, 2020
@AnnaShaleva
compiler: add multisig checks interops
0e86da1 
Part of #918
AnnaShaleva added a commit that referenced this issue Jul 14, 2020
@AnnaShaleva
core: rename Neo.Crypto.Verify to Neo.Crypto.VerifyWithECDsaSecp256r1
39a8570 
Part of #918
AnnaShaleva added a commit that referenced this issue Jul 14, 2020
@AnnaShaleva
core: rename Neo.Crypto.CheckMultisig to Neo.Crypto.CheckMultisigWith…
e94f493 
…ECDsaSecp256r1

Part of #918
AnnaShaleva added a commit that referenced this issue Jul 14, 2020
@AnnaShaleva
core: implement Secp256k1 Verify and CheckMultisig interops
3a5eab1 
Closes #918.
AnnaShaleva added a commit that referenced this issue Jul 14, 2020
@AnnaShaleva
compiler: add multisig checks interops
77330be 
Part of #918
AnnaShaleva added a commit that referenced this issue Jul 14, 2020
@AnnaShaleva
compiler: add CheckMultisig interops
7e10cc1 
Part of #918
AnnaShaleva added a commit that referenced this issue Jul 14, 2020
@AnnaShaleva
core: rename Neo.Crypto.Verify to Neo.Crypto.VerifyWithECDsaSecp256r1
d8bef26 
Part of #918
AnnaShaleva added a commit that referenced this issue Jul 14, 2020
@AnnaShaleva
core: rename Neo.Crypto.CheckMultisig to Neo.Crypto.CheckMultisigWith…
18a4676 
…ECDsaSecp256r1

Part of #918
AnnaShaleva added a commit that referenced this issue Jul 14, 2020
@AnnaShaleva
core: implement Secp256k1 Verify and CheckMultisig interops
3029967 
Closes #918.
AnnaShaleva added a commit that referenced this issue Jul 14, 2020
@AnnaShaleva
compiler: add CheckMultisig interops
9404bbc 
Part of #918
AnnaShaleva added a commit that referenced this issue Jul 14, 2020
@AnnaShaleva
core: rename Neo.Crypto.Verify to Neo.Crypto.VerifyWithECDsaSecp256r1
17233e1 
Part of #918
AnnaShaleva added a commit that referenced this issue Jul 14, 2020
@AnnaShaleva
core: rename Neo.Crypto.CheckMultisig to Neo.Crypto.CheckMultisigWith…
5326fc5 
…ECDsaSecp256r1

Part of #918
AnnaShaleva added a commit that referenced this issue Jul 14, 2020
@AnnaShaleva
core: implement Secp256k1 Verify and CheckMultisig interops
a3e306f 
Closes #918.
AnnaShaleva added a commit that referenced this issue Jul 14, 2020
@AnnaShaleva
compiler: add CheckMultisig interops
063a7f6 
Part of #918
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.91.0
Development

Successfully merging a pull request may close this issue.

crypto: add Secp256k1 support nspcc-dev/neo-go
1 participant
@roman-khimov