crypto: add Secp256k1 support #1175
Conversation
AnnaShaleva
force-pushed
the
neo3/crypto/ecdsa
branch
from
4f88d5e
to
0e86da1
Compare
Codecov Report
@@ Coverage Diff @@
## master #1175 +/- ##
==========================================
- Coverage 66.71% 66.70% -0.01%
==========================================
Files 198 198
Lines 16800 16829 +29
==========================================
+ Hits 11208 11226 +18
- Misses 4995 5006 +11
Partials 597 597
Continue to review full report at Codecov.
|
AnnaShaleva
force-pushed
the
neo3/crypto/ecdsa
branch
3 times, most recently
from
7e10cc1
to
9404bbc
Compare
| type PrivateKey struct { | ||
| b []byte | ||
| ecdsa.PrivateKey |
There was a problem hiding this comment.
type Private ecdsa.PrivateKey? I mean, this struct wrapper seems to be useless now.
There was a problem hiding this comment.
In this case method (*keys.PrivateKey).PublicKey() duplicates field (ecdsa.PrivateKey).PublicKey. At the same time we cannot remove the method as we need to have access to keys.PublicKey via keys.PrivateKey (not to ecdsa.PublicKey). So we can either rename (*keys.PrivateKey).PublicKey() or let PrivateKey remain a struct. What do you prefer?
There was a problem hiding this comment.
OK, let it be a struct for now, we can refactor it later.
pkg/crypto/keys/private_key.go
Outdated
| @@ -38,17 +48,35 @@ func NewPrivateKeyFromHex(str string) (*PrivateKey, error) { | |||
| return NewPrivateKeyFromBytes(b) | |||
| } | |||
|
|
|||
| // NewPrivateKeyFromBytes returns a NEO PrivateKey from the given byte slice. | |||
| // NewPrivateKeyFromBytes returns a NEO Secp256k1 PrivateKey from the given | |||
pkg/crypto/keys/publickey.go
Outdated
| type PublicKey struct { | ||
| X *big.Int | ||
| Y *big.Int | ||
| ecdsa.PublicKey |
There was a problem hiding this comment.
type Public ecdsa.PublicKey
Now we have not only Random EC curve, but also Koblitz curve, so it will be useful to have information about the curve for each particular EC point. ecdsa.PublicKey has this information.
…ECDsaSecp256r1 Part of #918
AnnaShaleva
force-pushed
the
neo3/crypto/ecdsa
branch
from
9404bbc
to
063a7f6
Compare
closes #918